[libvirt] [PATCH v2 16/25] qemu: blockjob: Track internal data for 'backup' blockjob

[Ján Tomko]

On Tue, Dec 03, 2019 at 06:17:38PM +0100, Peter Krempa wrote:
>A backup blockjob needs to be able to notify the parent backup job as
>well as track all data to be able to clean up the bitmap and blockdev
>used for the backup.
>
>Add the data structure, job allocation function and status XML formatter
>and parser.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_blockjob.c | 34 +++++++++++++++++++++++++++++++++-
> src/qemu/qemu_blockjob.h | 18 ++++++++++++++++++
> src/qemu/qemu_domain.c   | 21 +++++++++++++++++++++
> 3 files changed, 72 insertions(+), 1 deletion(-)
>
>diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
>index 5455eaba65..d434b8bddd 100644
>--- a/src/qemu/qemu_blockjob.c
>+++ b/src/qemu/qemu_blockjob.c
>@@ -78,8 +78,12 @@ qemuBlockJobDataDisposeJobdata(qemuBlockJobDataPtr job)
> {
>     if (job->type == QEMU_BLOCKJOB_TYPE_CREATE)
>         virObjectUnref(job->data.create.src);
>-}
>

This odd diff is caused by your disruption to the whitespace serenity.

>+    if (job->type == QEMU_BLOCKJOB_TYPE_BACKUP) {
>+        virObjectUnref(job->data.backup.store);
>+        g_free(job->data.backup.bitmap);
>+    }
>+}
>
> static void
> qemuBlockJobDataDispose(void *obj)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191209/a8a84270/attachment-0001.sig>