[libvirt] [jenkins-ci PATCH 03/22] guests, jenkins: Add CentOS 8

[Andrea Bolognani]

On Mon, 2019-12-09 at 16:20 +0100, Fabiano Fidêncio wrote:
> guests,jenkins: Add CentOS 8

s/,jenkins//

[...]
> diff --git a/guests/playbooks/build/jobs/defaults.yml b/guests/playbooks/build/jobs/defaults.yml
> index 0175a05..5e4ec03 100644
> --- a/guests/playbooks/build/jobs/defaults.yml
> +++ b/guests/playbooks/build/jobs/defaults.yml
> @@ -1,6 +1,7 @@
>  ---
>  all_machines:
>    - libvirt-centos-7
> +  - libvirt-centos-8
>    - libvirt-debian-9
>    - libvirt-debian-10
>    - libvirt-debian-sid
> @@ -15,6 +16,7 @@ all_machines:
>    - libvirt-ubuntu-1804
>  rpm_machines:
>    - libvirt-centos-7
> +  - libvirt-centos-8
>    - libvirt-fedora-30
>    - libvirt-fedora-31
>    - libvirt-fedora-rawhide
> diff --git a/jenkins/jobs/defaults.yaml b/jenkins/jobs/defaults.yaml
> index 676ecbf..9232d42 100644
> --- a/jenkins/jobs/defaults.yaml
> +++ b/jenkins/jobs/defaults.yaml
> @@ -4,6 +4,7 @@
>      node: libvirt
>      all_machines:
>        - libvirt-centos-7
> +      - libvirt-centos-8
>        - libvirt-debian-9
>        - libvirt-debian-10
>        - libvirt-fedora-30
> @@ -13,6 +14,7 @@
>        - libvirt-freebsd-12
>      rpm_machines:
>        - libvirt-centos-7
> +      - libvirt-centos-8
>        - libvirt-fedora-30
>        - libvirt-fedora-31
>        - libvirt-fedora-rawhide

These changes are not wrong per se, but I would prefer it if the
series had a different structure:

  * set the stage
    + this is your first two patches

  * add support for installing a CentOS 8 guest
    + all the other hunks of this patch plus the next two
    + './lcitool install libvirt-centos-8' now works
    + happens entirely inside the guests/ directory

  * add projects to CentOS 8 one by one
    + one patch per project
    + just tweak the mappings as needed and add the corresponding
      project to host_vars/libvirt-centos-8/main.yml when done
    + './lcitool update libvirt-centos-8 $project' should succeed
      with the patch applied
    + also requires touching guests/ only

  * start building projects on CentOS 8
    + single patch that enables everything
    + touches guests/playbooks/build/ and jenkins/ only

This structure makes more sense to me because adding
libvirt-centos-8 to all_machines feels really wrong when you know
that, at that point in time, you wouldn't actually be able to build
a single project on the resulting guest.


So, in conclusion:

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

to all other hunks, but save these last few for later.

-- 
Andrea Bolognani / Red Hat / Virtualization