[libvirt] [jenkins-ci PATCH 03/22] guests, jenkins: Add CentOS 8

[Andrea Bolognani]

On Mon, 2019-12-09 at 18:29 +0100, Andrea Bolognani wrote:
> These changes are not wrong per se, but I would prefer it if the
> series had a different structure:
> 
>   * set the stage
>     + this is your first two patches
> 
>   * add support for installing a CentOS 8 guest
>     + all the other hunks of this patch plus the next two
>     + './lcitool install libvirt-centos-8' now works
>     + happens entirely inside the guests/ directory
> 
>   * add projects to CentOS 8 one by one
>     + one patch per project
>     + just tweak the mappings as needed and add the corresponding
>       project to host_vars/libvirt-centos-8/main.yml when done
>     + './lcitool update libvirt-centos-8 $project' should succeed
>       with the patch applied
>     + also requires touching guests/ only

Taking half a step back after giving a second look to the rest of the
series, once you split the changes to playbooks/build/ and jenkins/
off to a separate patch there's very little point in having one patch
per project, as the changes to mappings.yml and host_vars/ in patches
6,7 and 12-22 are small and straighforward enough that it would make
more sense to have them all together. So let's do that instead.

I don't see the need to add further comments to this incarnation of
the series. The only remaining question IMHO is whether we can get
away without patches 8-11 - I really don't like those :)

-- 
Andrea Bolognani / Red Hat / Virtualization