[libvirt] [PATCH v2 0/1] qemu: fix crash bug in snapshot revert

Pavel Mores pmores at redhat.com
Tue Dec 10 14:36:07 UTC 2019


This is a significant rework of v1 as

- patch 1 was dropped because an equivalent change was accidentally committed
  in the meantime in 4c53267b70fc5c548b6530113c3f96870d8d7fc1
- patch 2 was dropped as it was just a mostly formal clean-up of patch 1
- patch 3 was redone using a different approach.

Patch 3 now takes the approach that was hinted at in the last paragraph of
v1's cover letter, more specifically it now fixes qemuProcessStop() rather
than its caller.  Digging into git history I located the commit that
introduced qemuProcessStop()'s problematic behaviour and after consulting with
Michal, we agreed that fixing qemuProcessStop() seems safe enough, and
definitely a better solution conceptually.

Pavel Mores (1):
  qemu: fix concurrency crash bug in snapshot revert

 src/qemu/qemu_domain.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

-- 
2.21.0




More information about the libvir-list mailing list