[libvirt] [PATCH v1 00/26] move qemucaps validations from qemu_command to qemu_domain

[Peter Krempa]

On Tue, Dec 10, 2019 at 19:45:01 -0300, Daniel Henrique Barboza wrote:
> 
> 
> On 12/10/19 5:00 AM, Peter Krempa wrote:
> > On Mon, Dec 09, 2019 at 20:15:05 -0300, Daniel Henrique Barboza wrote:
> > > (series based on master commit 97cafa610ecf5)
> > > 
> > > This work was proposed by Cole in [1]. This is Cole's reasoning for
> > > it, copy/pasted from [1]:
> > 
> > Nice work. Doing this was long overdue. My only suggestion is that after
> > this we should move all validation into a separate file. qemu_domain was
> > a code dumping place for a long time and since we now have a lot of
> > common code moving it out would be benficial for cleaning up an making
> > it more obvious.
> 
> 
> Got it. We can create this new file and move the validations from qemu_domain.c
> to the new file,  before resuming moving more code out of qemu_command.c. That way
> we avoid moving the code twice.

Since you've got patches already it's okay to do it in two steps. It
will be much appreciated if you move it to a new file, but it's not
required for this series.