[libvirt] [jenkins-ci PATCH v2 6/8] guests: Enable PowerTools repo on CentOS 8 guests

Fabiano Fidêncio fidencio at redhat.com
Wed Dec 11 12:53:06 UTC 2019


On Wed, Dec 11, 2019 at 1:33 PM Andrea Bolognani <abologna at redhat.com> wrote:
>
> On Wed, 2019-12-11 at 13:26 +0100, Fabiano Fidêncio wrote:
> > And this is the fixup for this one:
> > ```
> > diff --git a/guests/lcitool b/guests/lcitool
> > index 059b789..c28c414 100755
> > --- a/guests/lcitool
> > +++ b/guests/lcitool
> > @@ -749,13 +749,23 @@ class Application:
> >                          {package_manager} clean all -y
> >                  """).format(**varmap))
> >              elif os_name == "CentOS":
> > -                sys.stdout.write(textwrap.dedent("""
> > -                    RUN {package_manager} update -y && \\
> > -                        {package_manager} install -y epel-release && \\
> > -                        {package_manager} install -y {pkgs} && \\
> > -                        {package_manager} autoremove -y && \\
> > -                        {package_manager} clean all -y
> > -                """).format(**varmap))
> > +                if os_version == "7":
> > +                    sys.stdout.write(textwrap.dedent("""
> > +                        RUN {package_manager} update -y && \\
> > +                            {package_manager} install -y epel-release && \\
> > +                            {package_manager} install -y {pkgs} && \\
> > +                            {package_manager} autoremove -y && \\
> > +                            {package_manager} clean all -y
> > +                    """).format(**varmap))
> > +                else:
> > +                    sys.stdout.write(textwrap.dedent("""
> > +                        RUN {package_manager} update -y && \\

+                            {package_manager} install
'dnf-command(config-manager)' -y && \\

This is also needed: ^

> > +                            {package_manager} config-manager
> > --set-enabled PowerTools -y && \\
> > +                            {package_manager} install -y epel-release && \\
> > +                            {package_manager} install -y {pkgs} && \\
> > +                            {package_manager} autoremove -y && \\
> > +                            {package_manager} clean all -y
> > +                    """).format(**varmap))
> >              else:
> >                  sys.stdout.write(textwrap.dedent("""
> >                      RUN {package_manager} update -y && \\
> >
> > ```
>
> Also looks good!
>

I'll push the patches when python3-flakes8 update reaches EPEL.

Best Regards,
-- 
Fabiano Fidêncio





More information about the libvir-list mailing list