[libvirt] [jenkins-ci PATCH 2/2] lcitool: Refactor Dockerfile generation

Fabiano Fidêncio fidencio at redhat.com
Thu Dec 12 13:49:49 UTC 2019


[snip]

> +
> +            commands.extend([
> +                "{package_manager} update -y",
> +                "{package_manager} install -y {pkgs}",
> +                "{package_manager} autoremove -y",

This is going to be fun when we enable OpenSUSE support for container
generation. `zypper autoremove -y` is not a valid command and we'll
have to break this part.

With this in mind, I'm not sure whether it'd be worth to have a proper
mapping of the distros and the commands they support, having Fedora /
CentOS as the base.

What do you think?

Mind, I'm not pushing for the mapping, just pointing it out. :-). I'm
fine with an `if os_name != "OpenSUSE": ...`

[snip]

Best Regards,
-- 
Fabiano Fidêncio





More information about the libvir-list mailing list