[libvirt] [jenkins-ci PATCH 5/5] lcitool: Make Dockerfile generation work on openSUSE
Fabiano Fidêncio
fidencio at redhat.com
Thu Dec 12 14:39:37 UTC 2019
[snip]
>
> + # openSUSE doesn't seem to have a convenient way to remove all
> + # unnecessary packages, but CentOS and Fedora do
> + if os_name == "OpenSUSE":
> + commands.extend([
> + "{package_manager} clean --all",
> + ])
> + else:
> + commands.extend([
> + "{package_manager} autoremove -y",
> + "{package_manager} clean all -y",
> + ])
> +
IMHO, it'd be easier to follow / cleaner if we do:
if os_name != "OpenSUSE:"
commands.extend([
"{package_manager} autoremove -y",
])
And then, later on ...
commands.extend([
"{package_manager} clean all -y",
])
[snip]
Best Regards,
--
Fabiano Fidêncio
More information about the libvir-list
mailing list