[libvirt] [PATCH 6/8] qemu: don't hold monitor job for GetGuestInfo()

Michal Privoznik mprivozn at redhat.com
Thu Dec 12 14:47:11 UTC 2019


On 12/5/19 5:08 PM, Jonathon Jongsma wrote:
> We have to assume that the guest agent may be malicious so we don't want
> to allow any agent queries to block any other libvirt API. By holding a
> monitor job while we're querying the agent, we open ourselves up to a
> DoS.
> 
> This function issues several agent commands, but does not issue any
> monitor commands. Therefore, we can drop the monitor job and only hold
> an agent job.
> 
> Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
> ---
>   src/qemu/qemu_driver.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)

Same reasoning as to the previous one.

Michal




More information about the libvir-list mailing list