[libvirt] [jenkins-ci PATCH 1/5] guests: Add mapping for augeas-lenses

[Andrea Bolognani]

On Thu, 2019-12-12 at 16:42 +0100, Pino Toscano wrote:
> OTOH, in the mapping file I see:
> 
>    augeas:
>      default: augeas
>      deb: augeas-tools
> 
> This means that most probably there are different packages installed
> depending on the distro:
> - on Debian-based distros you get the command line tools
> - on some distros (mostly RPM-based) you get only the shared library
> - on some other distros (FreeBSD, and Linux distros not handled yet)
>   you may get either everything, or the command line tools

I guess a better name for the mapping would indeed be 'augtool',
because that's what we're trying to install. And it works as
intended, even on CentOS and Fedora despite what you wrote above.

> OTOH², looking at the spec [1] makes me sad, as nothing really
> depends on augeas-lenses, neither the shared library package nor the
> tools package :-( This is totally nonsense, you install augeas in
> openSUSE and it is broken by default if you have recommends disabled...

YaST2 apparently requires augeas-lenses[1], so while I agree that
the current situation is probably broken the issue will not actually
not show up in most openSUSE installations.

> So my suggestion is to limit the manual lenses installation only on
> openSUSE, as any other distro is already doing a sane job in this case.

We usually don't do that. Even though we would expect that installing
augtool would bring in the lenses as well, there's really nothing
inherently wrong with installing the lenses explicitly: different
distros have different granularity, so it's quite common that we end
up resolving multiple mappings to the same concrete package, and in
fact we have code in place to deal with just that situation.

tl;dr openSUSE might want to fix their dependencies, but as far as
      I'm concerned the current situation in libvirt-jenkins-ci is
      perfectly fine and I'm in no hurry to change it.


[1] https://www.redhat.com/archives/libvir-list/2019-December/msg00858.html
-- 
Andrea Bolognani / Red Hat / Virtualization