[libvirt] [PATCH 07/19] qemu: Check for explicit failure of qemuBlockSnapshotAddBlockdev

Eric Blake eblake at redhat.com
Thu Dec 12 19:13:18 UTC 2019


On 12/12/19 11:18 AM, Peter Krempa wrote:
> Check that the value is less than 0.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_driver.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 4d77fd6f6a..41a124d215 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -15533,7 +15533,7 @@ qemuDomainSnapshotCreateDiskActive(virQEMUDriverPtr driver,
>           if (blockdev) {
>               if (qemuBlockSnapshotAddBlockdev(actions,
>                                                diskdata[i].disk,
> -                                             diskdata[i].src))
> +                                             diskdata[i].src) < 0)

Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list