[libvirt] [PATCH 11/19] tests: qemublock: Add test case for detecting bitmaps as we create snapshots

[Eric Blake]

On 12/12/19 11:18 AM, Peter Krempa wrote:
> Add test data gathered from a run of qemu after creating bitmaps and
> snapshots together in various combinations.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   tests/qemublocktest.c                         |   1 +
>   tests/qemublocktestdata/bitmap/snapshots.json | 836 ++++++++++++++++++

Huge!

>   tests/qemublocktestdata/bitmap/snapshots.out  |  14 +

But looks like a good summary of potential configurations.

>   3 files changed, 851 insertions(+)
>   create mode 100644 tests/qemublocktestdata/bitmap/snapshots.json
>   create mode 100644 tests/qemublocktestdata/bitmap/snapshots.out
> 

> +            "filename": "/tmp/pull4.1575911550",
> +            "cluster-size": 65536,
> +            "format": "qcow2",
> +            "actual-size": 212992,
> +            "format-specific": {
> +                "type": "qcow2",
> +                "data": {
> +                    "compat": "1.1",
> +                    "lazy-refcounts": false,
> +                    "bitmaps": [
> +                        {

It's annoying that qemu semi-duplicates information between "bitmaps"...


> +        "backing_file": "/tmp/pull4.1575911540",
> +        "dirty-bitmaps": [
> +            {

and "dirty-bitmaps", but you appear to be grabbing the intended field.


> +++ b/tests/qemublocktestdata/bitmap/snapshots.out
> @@ -0,0 +1,14 @@
> +libvirt-1-format:
> +        d: recod:0 busy:0 persist:1 inconist:0 gran:65536 dirty:0
> +  current: recod:1 busy:0 persist:1 inconist:0 gran:65536 dirty:0

More fallout from typo fixes earlier in the series.

Reviewed-by: Eric Blake <eblake at redhat.com>

> +libvirt-2-format:
> +        c: recod:0 busy:0 persist:1 inconist:0 gran:65536 dirty:0
> +        d: recod:1 busy:0 persist:1 inconist:0 gran:65536 dirty:0
> +libvirt-3-format:
> +        a: recod:0 busy:0 persist:1 inconist:0 gran:65536 dirty:0
> +        b: recod:0 busy:0 persist:1 inconist:0 gran:65536 dirty:0
> +        c: recod:1 busy:0 persist:1 inconist:0 gran:65536 dirty:0
> +libvirt-4-format:
> +        a: recod:1 busy:0 persist:1 inconist:0 gran:65536 dirty:0
> +libvirt-5-format:
> +        a: recod:1 busy:0 persist:1 inconist:0 gran:65536 dirty:0
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org