[libvirt] [PATCH 13/19] qemu: backup: Extract calculations of bitmaps to merge for incremental backup

[Eric Blake]

On 12/12/19 11:18 AM, Peter Krempa wrote:
> Separate the for now incomplete code that collects the bitmaps to be
> merged for an incremental backup into a separate function. This will
> allow to add testing prior to the improvement of the algorithm to

"allow to $VERB" is not idiomatic English; you generally want "allow 
$SUBJECT to $VERB" or "allow ${VERB}ing".  Here, "This will allow the 
addition of testing prior to ..."

> include snapshots.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   src/qemu/qemu_backup.c | 37 +++++++++++++++++++++++++------------
>   1 file changed, 25 insertions(+), 12 deletions(-)
> 

The refactoring is sane.
Reviewed-by: Eric Blake <eblake at redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org