[libvirt] [PATCH v4 6/7] remote: shrink the critical sections

[Cole Robinson]

On 12/12/19 9:13 AM, Marc Hartmayer wrote:
> On Wed, Dec 11, 2019 at 07:48 PM -0500, Cole Robinson <crobinso at redhat.com> wrote:
>> On 11/14/19 12:44 PM, Marc Hartmayer wrote:
>>> To free the structs and save the error, it is not necessary to hold @priv->lock,
>>> therefore move these parts after the mutex unlock.
>>>
>>> Signed-off-by: Marc Hartmayer <mhartmay at linux.ibm.com>
>>> ---
>>>  src/remote/remote_daemon_dispatch.c | 32 ++++++++++++++---------------
>>>  1 file changed, 16 insertions(+), 16 deletions(-)
>>
>> Reviewed-by: Cole Robinson <crobinso at redhat.com>
>>
>> Do I understand correctly that 1,3-5 are all independent and can be
>> pushed separately? If so I will do that tomorrow. I'm doing some
>> archaeology on patch #2
> 
> 1, 3, and 5 are all independent.
> 
> Patch 4 depends on the second patch as
> remoteDispatchConnectRegisterCloseCallback uses
> virConnectRegisterCloseCallback. Otherwise we would never do the unref
> for @client and @program when conn->driver->connectRegisterCloseCallback
> was NULL.

Thanks, I pushed 1, 3, 5, 6. I'll reply to your other message

- Cole