[libvirt] [PATCH 5/5] virsh: show memoryBW info in 'virsh domstats' command

[Wang, Huaqiang]

> -----Original Message-----
> From: Daniel P. Berrangé <berrange at redhat.com>
> Sent: Friday, December 13, 2019 11:56 PM
> To: Wang, Huaqiang <huaqiang.wang at intel.com>
> Cc: libvir-list at redhat.com
> Subject: Re: [libvirt] [PATCH 5/5] virsh: show memoryBW info in 'virsh
> domstats' command
> 
> On Thu, Nov 14, 2019 at 01:08:23AM +0800, Wang Huaqiang wrote:
> > From: Huaqiang <huaqiang.wang at intel.com>
> >
> > Introduce an option '--memory' for showing memory related information.
> > The memory bandwidth infomatio is listed as:
> >
> > Domain: 'libvirt-vm'
> >   memory.bandwidth.monitor.count=4
> >   memory.bandwidth.monitor.0.name=vcpus_0-4
> >   memory.bandwidth.monitor.0.vcpus=0-4
> >   memory.bandwidth.monitor.0.node.count=2
> >   memory.bandwidth.monitor.0.node.0.id=0
> >   memory.bandwidth.monitor.0.node.0.bytes.total=10208067584
> >   memory.bandwidth.monitor.0.node.0.bytes.local=4807114752
> >   memory.bandwidth.monitor.0.node.1.id=1
> >   memory.bandwidth.monitor.0.node.1.bytes.total=8693735424
> >   memory.bandwidth.monitor.0.node.1.bytes.local=5850161152
> >   memory.bandwidth.monitor.1.name=vcpus_7
> >   memory.bandwidth.monitor.1.vcpus=7
> >   memory.bandwidth.monitor.1.node.count=2
> >   memory.bandwidth.monitor.1.node.0.id=0
> >   memory.bandwidth.monitor.1.node.0.bytes.total=853811200
> >   memory.bandwidth.monitor.1.node.0.bytes.local=290701312
> >   memory.bandwidth.monitor.1.node.1.id=1
> >   memory.bandwidth.monitor.1.node.1.bytes.total=406044672
> >   memory.bandwidth.monitor.1.node.1.bytes.local=229425152
> >
> > Signed-off-by: Huaqiang <huaqiang.wang at intel.com>
> > ---
> >  include/libvirt/libvirt-domain.h |  1 +
> >  src/libvirt-domain.c             | 21 +++++++
> >  src/qemu/qemu_driver.c           | 99 ++++++++++++++++++++++++++++++++
> >  tools/virsh-domain-monitor.c     |  7 +++
> >  tools/virsh.pod                  | 23 +++++++-
> 
> Unfortunately this doesn't apply since I converted the manpages from POD
> to RST.
> 
> Can you resend with update to docs/manpages/virsh.rst instead
> 

Got. I'll make a update and resend after we fixed patch 1/5. 

Thanks for review!
Huaqiang

> >  5 files changed, 149 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/libvirt/libvirt-domain.h
> > b/include/libvirt/libvirt-domain.h
> > index 22277b0a84..2b621ff162 100644
> > --- a/include/libvirt/libvirt-domain.h
> > +++ b/include/libvirt/libvirt-domain.h
> > @@ -2146,6 +2146,7 @@ typedef enum {
> >      VIR_DOMAIN_STATS_BLOCK = (1 << 5), /* return domain block info */
> >      VIR_DOMAIN_STATS_PERF = (1 << 6), /* return domain perf event info
> */
> >      VIR_DOMAIN_STATS_IOTHREAD = (1 << 7), /* return iothread poll
> > info */
> > +    VIR_DOMAIN_STATS_MEMORY= (1 << 8), /* return domain memory
> info
> > + */
> 
> Nitpick, whitespace before '='
> 
> >  } virDomainStatsTypes;
> 
> Regards,
> Daniel
> --
> |: https://berrange.com      -o-
> https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org         -o-            https://fstop138.berrange.com :|
> |: https://entangle-photo.org    -o-
> https://www.instagram.com/dberrange :|