[libvirt] [PATCH] qemu: homogenize MAC address in live & config when hotplugging a netdev

[Laine Stump]

On 12/17/19 1:45 PM, Michal Prívozník wrote:
> On 12/17/19 6:04 PM, Laine Stump wrote:

...

>> +static void
>> +qemuDomainAttachDeviceLiveAndConfigHomogenize(const virDomainDeviceDef *devConf,
>> +                                              virDomainDeviceDefPtr devLive)
>> +{
>> +    /*
>> +     * fixup anything that needs to be identical in the live and
> 
> s/fixup/Fixup/
> 
>> +     * config versions of DeviceDef, but might not be. Do this by
>> +     * changing the contents of devLive.
> 
> We need to warn everybody that only "small" changes are okay. I mean, we
> probably don't have to explicitly warn about not changing PCI address,
> but something among these lines should do:

Yeah, I thought of adding a warning, and actually was going to 
specifically mention that PCI/etc addresses shouldn't be changed (since 
that was something people have already talked about adjusting), but then 
forgot. I'll add in something like you suggest before pushing.

Thanks!