[libvirt] [PATCH 09/42] secret: Don't check the output of virGetUserConfigDirectory()

Fabiano Fidêncio fidencio at redhat.com
Thu Dec 19 10:04:14 UTC 2019


virGetUserConfigDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
---
 src/secret/secret_driver.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c
index 93b4256450..cdc4b7dcf9 100644
--- a/src/secret/secret_driver.c
+++ b/src/secret/secret_driver.c
@@ -475,8 +475,7 @@ secretStateInitialize(bool privileged,
         g_autofree char *rundir = NULL;
         g_autofree char *cfgdir = NULL;
 
-        if (!(cfgdir = virGetUserConfigDirectory()))
-            goto error;
+        cfgdir = virGetUserConfigDirectory();
         driver->configDir = g_strdup_printf("%s/secrets/", cfgdir);
 
         if (!(rundir = virGetUserRuntimeDirectory()))
-- 
2.24.1




More information about the libvir-list mailing list