[libvirt] [PATCH 41/42] admin: Use g_autofree on getSocketPath()

Ján Tomko jtomko at redhat.com
Thu Dec 19 19:33:09 UTC 2019


On Thu, Dec 19, 2019 at 05:22:32PM +0100, Fabiano Fidêncio wrote:
>On Thu, Dec 19, 2019 at 5:14 PM Pavel Hrdina <phrdina at redhat.com> wrote:
>>
>> On Thu, Dec 19, 2019 at 11:04:46AM +0100, Fabiano Fidêncio wrote:
>> > Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
>> > ---
>> >  src/admin/libvirt-admin.c | 3 +--
>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> s/on/in/ $SUBJECT?
>>
>> This might be the case for other patches as well.
>
>Noted.
>
>>
>> One note, I would say it's ok to squash some of the patches from this
>> series together, for example all the g_autofree patches per file for
>> example.
>
>I really thought about that. However, it may be misleading as I'm not
>touching all the possible conversions to use g_autofree in the other
>functions.

Well this case is also misleading, since you aren't touching all the
possible g_autofree conversions in this functions

Jano

>
>>
>> Pavel
>
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191219/12c6562e/attachment-0001.sig>


More information about the libvir-list mailing list