[libvirt] [PATCH 0/5] Get rid of "no_memory" labels

Fabiano Fidêncio fidencio at redhat.com
Fri Dec 20 12:43:10 UTC 2019


As pointed out by Ján Tomko, "no_memory seems suspicious in the times of
abort()".

As libvirt decided to take the path to not report OOM and simply abort
when it happens, let's get rid of the no_memory labels and simplify the
code around them.

The two exceptions are:
- phyp code, as libvirt may end up dropping this code entirely;
- virfirewall.c code, as it seems we heavily really on firewall->err
  being set to ENOMEM;

If one thinks that virfirewall.c should also be converted, please, shout
out and I'll work on that.

Fabiano Fidêncio (5):
  conf: Get rid of "no_memory" labels
  openvz: Get rid of "no_memory" labels
  rpc: Get rid of "no_memory" labels
  util: Get rid of "no_memory" labels
  vbox: Get rid of "no_memory" labels

 src/conf/capabilities.c  | 16 ++--------
 src/conf/domain_audit.c  | 40 +++++++------------------
 src/openvz/openvz_conf.c | 18 +++++------
 src/rpc/virnetclient.c   | 42 ++++++++------------------
 src/util/virsysinfo.c    | 64 +++++++++++++++-------------------------
 src/util/virsysinfo.h    |  2 ++
 src/util/viruri.c        | 28 +++++++-----------
 src/vbox/vbox_common.c   | 20 +++++--------
 8 files changed, 75 insertions(+), 155 deletions(-)

-- 
2.24.1




More information about the libvir-list mailing list