[libvirt] [PATCH RFC 09/11] conf: backup: Allow configuration of names exported via NBD

[Eric Blake]

On 12/20/19 7:25 AM, Peter Krempa wrote:
> If users wish to use different name for exported disks or bitmaps

different names

> the new fields allow to do so. Additionally they also document the

allow this possibility.

> current settings.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   docs/formatbackup.html.in                             |  9 +++++++++
>   docs/schemas/domainbackup.rng                         |  8 ++++++++
>   src/conf/backup_conf.c                                | 11 +++++++++++
>   src/conf/backup_conf.h                                |  2 ++
>   tests/domainbackupxml2xmlin/backup-pull-seclabel.xml  |  2 +-
>   tests/domainbackupxml2xmlout/backup-pull-seclabel.xml |  2 +-
>   6 files changed, 32 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatbackup.html.in b/docs/formatbackup.html.in
> index 1c690901c7..7d2c6f1599 100644
> --- a/docs/formatbackup.html.in
> +++ b/docs/formatbackup.html.in
> @@ -85,6 +85,15 @@
>                 <dd>Setting this attribute to <code>yes</code>(default) specifies
>                   that the disk should take part in the backup and using
>                   <code>no</code> excludes the disk from the backup.</dd>
> +              <dt><code>exportname</code></dt>
> +              <dd>Allows to modify the NBD export name for the given disk.

Allows modificatino of the NBD export name...

> +                By default equal to disk target.
> +                Valid only for pull mode backups. </dd>

Why a space after '.'?

> +              <dt><code>exportbitmap</code></dt>
> +              <dd>Allows to modify the name of the bitmap describing dirty

Allows modification of the name of the bitmap

> +                blocks for an incremental backup exported via NBD export name
> +                for the given disk.
> +                Valid only for pull mode backups. </dd>

and another space

>                 <dt><code>type</code></dt>
>                 <dd>A mandatory attribute to describe the type of the
>                   disk, except when <code>backup='no'</code> is
> diff --git a/docs/schemas/domainbackup.rng b/docs/schemas/domainbackup.rng
> index c1e4d80302..395ea841f9 100644
> --- a/docs/schemas/domainbackup.rng
> +++ b/docs/schemas/domainbackup.rng
> @@ -165,6 +165,14 @@
>               <attribute name='name'>
>                 <ref name='diskTarget'/>
>               </attribute>
> +            <optional>
> +              <attribute name='exportname'>
> +                <text/>
> +              </attribute>
> +              <attribute name='exportbitmap'>
> +                <text/>
> +              </attribute>
> +            </optional>

Do we need any limits (for example, qcow2 rejects bitmap names longer 
than 1k)?



-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org