[libvirt] [PATCH] qemu: Warn of restore with managed save being risky

[Michael Weiser]

Hi Daniel,

On Tue, Dec 31, 2019 at 05:19:54PM -0300, Daniel Henrique Barboza wrote:

> > This patch marks the restore operation as risky at the libvirt level,
> > requiring the user to remove the saved memory state first or force the
> > operation.
> > 
> > [1] https://www.redhat.com/archives/virt-tools-list/2019-November/msg00011.html
> > [2] https://www.redhat.com/archives/virt-tools-list/2019-December/msg00049.html
> > 
> > Signed-off-by: Michael Weiser <michael.weiser at gmx.de>
> > Cc: Cole Robinson <crobinso at redhat.com>
> > ---
> As said in [1], I agree that the API needs a flag override to allow the user
> to roll with it despite the risks. Given that this is somewhat a corner case,
> I also believe that such override can go in a separated patch/series later
> on.

Do you mean a separate override flag beyond
VIR_DOMAIN_SNAPSHOT_REVERT_FORCE? Or should I just update the commit
message to make clear how the user can force the operation?

> Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

Thanks!
-- 
Michael