[libvirt] [PATCH v2 1/7] configure: change HAVE_FIREWALLD to WITH_FIREWALLD

[Daniel P. Berrangé]

On Thu, Jan 31, 2019 at 08:24:52PM -0500, Laine Stump wrote:
> Support for firewalld is a feature that can be selectively enabled or
> disabled (using --with-firewalld/--without-firewalld), not merely
> something that must be accounted for in the code if it is present with
> no exceptions. It is more consistent with other usage in libvirt to
> use WITH_FIREWALLD rather than HAVE_FIREWALLD.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
> 
> New patch in V2 (NB, I already pushed patch 1 from V1, as it was
> ACKed, and not directly related to the rest of the series)
> 
> m4/virt-firewalld.m4           | 4 ++--
>  src/network/bridge_driver.c    | 6 +++---
>  src/nwfilter/nwfilter_driver.c | 6 +++---
>  3 files changed, 8 insertions(+), 8 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|