[libvirt] [PATCH v2 2/7] util: move all firewalld-specific stuff into its own files

[Daniel P. Berrangé]

On Thu, Jan 31, 2019 at 08:24:53PM -0500, Laine Stump wrote:
> In preparation for adding several other firewalld-specific functions,
> separate the code that's unique to firewalld from the more-generic
> "firewall" file.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
> 
> Change from V1: define VIR_FIREWALL_FIREWALLD_SERVICE in virfirewalldpriv.h,
> since it should only be used by virfirewalld.c and unit test programs.
> 
> (no, I haven't done anything about the awkward error checking that was
> already existing in the code I moved - not only is that a separate
> issue, but there no existing way to fix it anyway - that would take
> changes to firewalld)
> 
>  include/libvirt/virterror.h |   1 +
>  src/libvirt_private.syms    |   5 ++
>  src/util/Makefile.inc.am    |   3 +
>  src/util/virerror.c         |   3 +-
>  src/util/virfirewall.c      |  86 +-------------------
>  src/util/virfirewalld.c     | 151 ++++++++++++++++++++++++++++++++++++
>  src/util/virfirewalld.h     |  33 ++++++++
>  src/util/virfirewalldpriv.h |  30 +++++++
>  src/util/virfirewallpriv.h  |   2 -
>  tests/virfirewalltest.c     |   2 +
>  10 files changed, 231 insertions(+), 85 deletions(-)
>  create mode 100644 src/util/virfirewalld.c
>  create mode 100644 src/util/virfirewalld.h
>  create mode 100644 src/util/virfirewalldpriv.h

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|