[libvirt] [PATCH v2 6/7] network: allow configuring firewalld zone for virtual network bridge device

[Daniel P. Berrangé]

On Thu, Jan 31, 2019 at 08:24:57PM -0500, Laine Stump wrote:
> Since we're setting the zone anyway, it will be useful to allow
> setting a different (custom) zone for each network. This will be done
> by adding a "zone" attribute to the "bridge" element, e.g.:
> 
>    ...
>    <bridge name='virbr0' zone='myzone'/>
>    ...
> 
> If a zone is specified in the config and it can't be honored, this
> will be an error.
> 
> Signed-off-by: Laine Stump <laine at laine.org>
> ---
> 
> Change from V1: move news.xml additions to a separate patch, as requested.
> 
>  docs/firewall.html.in                      |  5 +++++
>  docs/formatnetwork.html.in                 | 17 +++++++++++++++++
>  docs/schemas/basictypes.rng                |  6 ++++++
>  docs/schemas/network.rng                   |  6 ++++++
>  src/conf/network_conf.c                    | 14 ++++++++++++--
>  src/conf/network_conf.h                    |  1 +
>  src/network/bridge_driver_linux.c          | 19 +++++++++++++++++++
>  tests/networkxml2xmlin/routed-network.xml  |  2 +-
>  tests/networkxml2xmlout/routed-network.xml |  2 +-
>  9 files changed, 68 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|