[libvirt] [PATCH] qemu: command: Don't skip 'readonly' and throttling info for empty drive

[Daniel P. Berrangé]

On Fri, Feb 01, 2019 at 06:00:37PM +0100, Peter Krempa wrote:
> In commit f80eae8c2ae I was too agresive in removing properties of
> -drive for empty drives. It turns out that qemu actually persists the
> state of 'readonly' and the throttling information even for the empty
> drive.
> 
> Removing 'readonly' thus made qemu open any subsequent images added via
> the 'change' command as RW which was forbidden by selinux thanks to the
> restrictive sVirt label for readonly media.
> 
> Fix this by formating the property again and bump the tests and leave a
> note detailing why the rest of the properties needs to be skipped.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/qemu/qemu_command.c                        | 18 +++++++++++++-----
>  tests/qemuxml2argvdata/disk-cdrom.args         |  4 ++--
>  .../disk-cdrom.x86_64-2.12.0.args              |  4 ++--
>  .../disk-cdrom.x86_64-latest.args              |  4 ++--
>  4 files changed, 19 insertions(+), 11 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|