[libvirt] [jenkins-ci PATCH v2 3/9] guests: fix glusterfs package name on Debian

Andrea Bolognani abologna at redhat.com
Wed Feb 6 16:03:16 UTC 2019


On Wed, 2019-02-06 at 15:57 +0000, Daniel P. Berrangé wrote:
> On Wed, Feb 06, 2019 at 03:58:37PM +0100, Andrea Bolognani wrote:
> > On Tue, 2019-02-05 at 17:53 +0000, Daniel P. Berrangé wrote:
> > [...]
> > >    glusterfs:
> > > -    deb: glusterfs-client
> > > +    deb: libglusterfs-dev
> > >      rpm: glusterfs-api-devel
> > 
> > This won't work, because before Debian Sid the libglusterfs-dev
> > package didn't exist and header files were included in the
> > glusterfs-common package.
> > 
> > So the correct solution is to do either
> > 
> >   glusterfs:
> >     deb: glusterfs-common
> >     rpm: glusterfs-api-devel
> >     DebianSid: libglusterfs-dev
> > 
> > or the more future-proof (and verbose)
> > 
> >   glusterfs:
> >     deb: libglusterfs-dev
> >     rpm: glusterfs-api-devel
> >     Debian8: glusterfs-common
> >     Debian9: glusterfs-common
> >     Ubuntu16: glusterfs-common
> >     Ubuntu18: glusterfs-common
> > 
> > I'd probably go for the latter.
> 
> Yeah preferring the future is better

Alright then!

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>

with that addressed.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list