[libvirt] [PATCH] conf: Remove iothreads restriction in virDomainDefCheckABIStabilityFlags

Cole Robinson crobinso at redhat.com
Wed Feb 6 22:09:50 UTC 2019


On 1/31/19 7:50 AM, Jie Wang wrote:
> The number of iothreads is not part of the vm state sent during
> migration, nor exposed to the guest ABI, so this restriction is
> a mistaken in libvirt. Let's remove that bit of code.
> 
> Signed-off-by: Jie Wang <wangjie88 at huawei.com>
> ---
>  src/conf/domain_conf.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index ae8fb5a501..ac4eeaec5e 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -22927,14 +22927,6 @@ virDomainDefCheckABIStabilityFlags(virDomainDefPtr src,
>      if (!virDomainDefVcpuCheckAbiStability(src, dst))
>          goto error;
>  
> -    if (src->niothreadids != dst->niothreadids) {
> -        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> -                       _("Target domain iothreads count %zu does not "
> -                         "match source %zu"),
> -                       dst->niothreadids, src->niothreadids);
> -        goto error;
> -    }
> -
>      if (src->os.type != dst->os.type) {
>          virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
>                         _("Target domain OS type %s does not match source %s"),
> 

Fixed s/mistaken/mistake/ in the commit message and pushed

Thanks,
Cole




More information about the libvir-list mailing list