[libvirt] [PATCH 2/4] qemu: Move shareable disk check for block copy

Ján Tomko jtomko at redhat.com
Thu Feb 7 12:58:59 UTC 2019


On Thu, Jan 31, 2019 at 02:43:48PM +0100, Peter Krempa wrote:
>The writing to an image actually starts when the copy job is initiated,
>so checking this at the time of the pivot operation is too late.
>
>Move the check to qemuDomainBlockCopyCommon. Note that modern qemu would
>have prevented two writers with qcow2 so the slim possibility of a job
>started with libvirtd without this patch missing the check is not really
>worth worrying about.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190207/7baf2a7a/attachment-0001.sig>


More information about the libvir-list mailing list