[libvirt] [PATCH 01/15] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageAuthDef

[Ján Tomko]

On Thu, Feb 07, 2019 at 07:12:08AM -0500, John Ferlan wrote:
>
>
>On 2/7/19 4:10 AM, Erik Skultety wrote:
>> On Wed, Feb 06, 2019 at 08:41:33AM -0500, John Ferlan wrote:
>>> Let's make use of the auto __cleanup capabilities cleaning up any
>>> now unnecessary goto paths. For virStorageAuthDefCopy use authdef
>>> and ret as consistently as similar other code.
>>>
>>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>>> ---
>>>  src/conf/domain_conf.c        | 29 +++++++++++------------------
>>>  src/conf/storage_conf.c       |  6 ++----
>>>  src/qemu/qemu_parse_command.c |  6 ++----
>>>  src/util/virstoragefile.c     | 33 ++++++++++++++-------------------
>>>  src/util/virstoragefile.h     |  1 +
>>>  5 files changed, 30 insertions(+), 45 deletions(-)
>>>

>>> +            VIR_STEAL_PTR(iscsisrc->src->auth, authdef);
>>
>> ^Unrelated change, there should be a trivial patch preceding this one taking
>> care of the VIR_STEAL_PTR replacements.
>>
>> ...
>
>You'll find this sprinkled throughout - generating separate patches
>could explode the series into perhaps 30+ patches which I doubt anyone
>would jump at the chance to review.  I can separate before pushing and I
>assume by extracting it/them I can just add your R-by too...
>

Splitting the changes into simple patches doing one thing at a time
actually makes review easier, even though it makes the series longer.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190207/603de4a6/attachment-0001.sig>