[libvirt] [PATCH v2 10/32] tests: qemuxml2argv: Use real caps when auto-generating SCSI controller type

Ján Tomko jtomko at redhat.com
Thu Feb 7 14:55:29 UTC 2019


On Mon, Feb 04, 2019 at 04:46:43PM +0100, Peter Krempa wrote:
>Using an old strict set of capabilities is not of much use if a code
>path would select a more modern controller on accident.

by accident?

>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> ...> disk-scsi-device-auto.x86_64-1.5.3.args} | 11 +++---
> .../disk-scsi-device-auto.x86_64-latest.args  | 35 +++++++++++++++++++
> tests/qemuxml2argvtest.c                      |  4 +--
> 3 files changed, 43 insertions(+), 7 deletions(-)
> rename tests/qemuxml2argvdata/{disk-scsi-device-auto.args => disk-scsi-device-auto.x86_64-1.5.3.args} (69%)
> create mode 100644 tests/qemuxml2argvdata/disk-scsi-device-auto.x86_64-latest.args
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190207/8b740ede/attachment-0001.sig>


More information about the libvir-list mailing list