[libvirt] [PATCH v2 11/32] tests: qemuxml2argv: Remove testing of post startup change to 'cachemode' for shared disks

Ján Tomko jtomko at redhat.com
Thu Feb 7 15:00:02 UTC 2019


On Mon, Feb 04, 2019 at 04:46:44PM +0100, Peter Krempa wrote:
>Testing that the cachemode is properly recorded to the configuration
>after startup does not add much value and overcomplicates the xml2argv
>test.
>
>Remove the 'disk-shared' test with old capabilities, which would be done
>along as well as the test with real capabilities covers it sufficiently.
>

-EPARSE

s/along //

>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> tests/qemuxml2argvdata/disk-shared.args       | 31 ----------
> tests/qemuxml2argvtest.c                      |  1 -
> .../qemuxml2startupxmloutdata/disk-shared.xml | 56 -------------------
> 3 files changed, 88 deletions(-)
> delete mode 100644 tests/qemuxml2argvdata/disk-shared.args
> delete mode 100644 tests/qemuxml2startupxmloutdata/disk-shared.xml
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190207/af927d71/attachment-0001.sig>


More information about the libvir-list mailing list