[libvirt] [PATCH 01/15] util: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageAuthDef

[Erik Skultety]

On Thu, Feb 07, 2019 at 04:24:13PM +0100, Andrea Bolognani wrote:
> On Thu, 2019-02-07 at 07:12 -0500, John Ferlan wrote:
> > On 2/7/19 4:10 AM, Erik Skultety wrote:
> > > On Wed, Feb 06, 2019 at 08:41:33AM -0500, John Ferlan wrote:
> > > > +VIR_DEFINE_AUTOPTR_FUNC(virStorageAuthDef, virStorageAuthDefFree);
> > >
> > > ^This defines a static function, so the ';' is unnecessary, it doesn't hurt,
> > > but you know, consistency ;). Also, keep the original newline below.
> >
> > Perhaps because I had recently reviewed Cole's series about removing the
>
> You meant *adding* here, right?
>
> > semicolon from VIR_ENUM_DECL, VIR_ENUM_IMPL, VIR_LOG_INIT, and
> > VIR_ONCE_GLOBAL_INIT - it was just "fresh" in my mind that macros should
> > have semicolons (moreso than actually looking at that definition).  I
> > can change them all.
>
> Please keep the semicolon! If a macro is used like a function, then
> its call sites should also look like those of a function.

Except VIR_DEFINE_AUTOPTR_FUNC macro is not used like a function, it defines a
function.

Erik