[libvirt] [PATCH 05/10] tests: qemuhotplug: Use DEVICE_DELETED event in all hotunplug tests

Ján Tomko jtomko at redhat.com
Thu Feb 7 16:20:03 UTC 2019


On Thu, Feb 07, 2019 at 01:28:09PM +0100, Peter Krempa wrote:
>Currently all supported qemu versions now have support for the
>DEVICE_DELETED event. This means that testing the old approach is a
>waste of time.
>
>Always add the QEMU_CAPS_DEVICE_DEL_EVENT capability in the hotplug test
>and fix existing test cases.
>
>The 'disk-virtio', 'disk-usb', 'disk-scsi', and 'disk-scsi-2' already
>had variants that used the event, so the non-event variants will be
>removed.
>
>For all other cases the QMP_DEVICE_DELETED macro is used to add the
>correct reply.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> tests/qemuhotplugtest.c | 59 +++++++++--------------------------------
> 1 file changed, 12 insertions(+), 47 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190207/52db01f0/attachment-0001.sig>


More information about the libvir-list mailing list