[libvirt] [PATCH 09/10] qemu: caps: Probe events from 'query-qmp-schema' rather than 'query-events'

Ján Tomko jtomko at redhat.com
Thu Feb 7 16:26:45 UTC 2019


On Thu, Feb 07, 2019 at 01:28:13PM +0100, Peter Krempa wrote:
>QEMU plans to deprecate 'query-events' as it's non-extensible. Events
>are also described by 'query-qmp-schema' so we can use that one instead.
>
>This patch adds detection of events to
>virQEMUCapsProbeQMPSchemaCapabilities using the same structure declaring
>them for the old approach (virQEMUCapsEvents). This is possible as the
>name is the same in the QMP schema and our detector supports that
>trivially.
>
>For any complex queries virQEMUCapsQMPSchemaQueries can be used in the
>future.
>
>For now we still call 'query-events' and discard the result so that it's
>obvious that the tests pass. This will be cleaned up later.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_capabilities.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190207/46a1a33d/attachment-0001.sig>


More information about the libvir-list mailing list