[libvirt] [PATCH v2 25/32] tests: qemuxml2argv: Add CDROM disks for all untested buses

[Ján Tomko]

On Mon, Feb 04, 2019 at 04:46:58PM +0100, Peter Krempa wrote:
>Add full and empty cdroms on 'usb', 'virtio', and 'sd' bus to have test

Feels odd to add 'virtio' here if you remove it in the next patch.

>coverage. Note that this does not guarantee that qemu will accept them.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> .../disk-cdrom-bus-other.x86_64-latest.args   | 45 +++++++++++++
> .../qemuxml2argvdata/disk-cdrom-bus-other.xml | 58 +++++++++++++++++
> tests/qemuxml2argvtest.c                      |  1 +
> .../disk-cdrom-bus-other.xml                  | 64 +++++++++++++++++++
> tests/qemuxml2xmltest.c                       |  1 +
> 5 files changed, 169 insertions(+)
> create mode 100644 tests/qemuxml2argvdata/disk-cdrom-bus-other.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/disk-cdrom-bus-other.xml
> create mode 100644 tests/qemuxml2xmloutdata/disk-cdrom-bus-other.xml
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190207/a999b8ce/attachment-0001.sig>