[libvirt] [PATCH v2 27/32] qemu: command: Drop formatting of 'media=cdrom' from -drive

Ján Tomko jtomko at redhat.com
Thu Feb 7 17:02:31 UTC 2019

On Mon, Feb 04, 2019 at 04:47:00PM +0100, Peter Krempa wrote:
>For SCSI, IDE, and AHCI cdroms the appropriate device types which select
>the correct media are used. In qemu there's one other code path that
>looks at -drive media=cdrom in the XEN pv code. Thankfully we don't
>support it with qemu (see qemuBuildDiskDeviceStr). All other devices
>ignore it as the comment states, thus we can drop that code.
>The test fallout is expectedly only in the test added for uncommon cdrom
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> src/qemu/qemu_command.c                                  | 9 ---------
> .../disk-cdrom-bus-other.x86_64-latest.args              | 9 ++++-----
> 2 files changed, 4 insertions(+), 14 deletions(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190207/50822a1f/attachment-0001.sig>

More information about the libvir-list mailing list