[libvirt] [tck PATCH 3/4] networks: remove stray use of brctl command

Laine Stump laine at laine.org
Fri Feb 8 03:08:30 UTC 2019


brctl has been deprecated for a long time, and distros are starting to
remove it. "ip link blah type bridge" should be used instead.

Signed-off-by: Laine Stump <laine at laine.org>
---
 scripts/networks/340-guest-network-bridge.t | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/networks/340-guest-network-bridge.t b/scripts/networks/340-guest-network-bridge.t
index e5db0ff..498bcb6 100644
--- a/scripts/networks/340-guest-network-bridge.t
+++ b/scripts/networks/340-guest-network-bridge.t
@@ -36,9 +36,9 @@ my $conn = eval { $tck->setup(); };
 BAIL_OUT "failed to setup test harness: $@" if $@;
 END { $tck->cleanup if $tck; }
 
-((system "brctl addbr tck") == 0) or die "cannot create bridge 'tck'";
+((system "ip link add name tck type bridge") == 0) or die "cannot create bridge 'tck'";
 
-END { system "brctl delbr tck" }
+END { system "ip link del tck" }
 
 my $b = Sys::Virt::TCK::NetworkBuilder->new(name => "tck");
 $b->bridge("tck");
-- 
2.20.1




More information about the libvir-list mailing list