[libvirt] [PATCH v2 14/32] util: Fix virStorageBackendSCSINewLun error handling

Erik Skultety eskultet at redhat.com
Mon Feb 11 11:59:41 UTC 2019


On Fri, Feb 08, 2019 at 01:37:08PM -0500, John Ferlan wrote:
> Commit a523770c3 added @retval return processing for
> virStorageBackendUpdateVolInfo in order to allow a -2
> to be return; however, upon successful completion
> @retval = 0 and if either the virStorageBackendSCSISerial
> or the virStoragePoolObjAddVol failed, the method would
> return 0, but not add the @vol to the pool. So let's
> just reset retval = -1 and continue processing.
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list