[libvirt] [PATCH v2 1/2] conf: add debugcon chardev guest interface

[Daniel P. Berrangé]

On Mon, Feb 11, 2019 at 02:40:55PM +0100, Andrea Bolognani wrote:
> On Mon, 2019-02-11 at 08:14 +0000, Nikolay Shirokovskiy wrote:
> > On 08.02.2019 17:34, Andrea Bolognani wrote:
> > > Even with that fixed, while your code prevents a <console> element
> > > associated to the isa-debugcon to be automatically created, it
> > > doesn't prevent something like
> > > 
> > >   <console type='pty'/>
> > >   <serial type='file'>
> > >     <source path='...'/>
> > >     <target type='isa-serial'>
> > >       <model name='isa-debugcon'/>
> > >     </target>
> > >   </serial>
> > > 
> > > to result in the same problematic configuration, while the user
> > > clearly wanted to have both a regular serial console *and* the
> > > isa-debugcon.
> > 
> > Yeah I noticed that too but I though this is like case of usb-serial
> > for example. We do not add missing console in that case but allow
> > existing console to be alias of usb-serial.
> 
> Hm, that looks like a bug. I think we should be consistent about
> this: either the aliasing between <serial/> and <console/> works
> both ways, or it should not happen at all IMHO.

I think that's fine in the case of usb-serial, as that's still an
admin interactive console channel, which is what our duplication
aims to represent.

It is not so good for isa-debugcon as that's is a special purpose
device.

> > Can usb-serial actually be console?
> 
> No idea :)

Yes, that's fine IMHO.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|