[libvirt] [PATCH v2 2/2] qemu: implement debugcon-isa chardev

[Ján Tomko]

On Fri, Feb 08, 2019 at 04:02:38PM +0100, Andrea Bolognani wrote:
>On Thu, 2019-02-07 at 14:31 +0300, Nikolay Shirokovskiy wrote:
>> +++ b/tests/qemuxml2argvtest.c
>> @@ -1490,6 +1490,7 @@ mymain(void)
>>              QEMU_CAPS_DEVICE_ISA_SERIAL);
>>      DO_TEST("pci-serial-dev-chardev",
>>              QEMU_CAPS_DEVICE_PCI_SERIAL);
>> +    DO_TEST("isa-serial-debugcon", NONE);
>>
>>      DO_TEST("channel-guestfwd", NONE);
>>      DO_TEST_CAPS_VER("channel-unix-guestfwd", "2.5.0");
>
>If you had included this hunk in the previous commit, then the
>QEMU command line would have been generated right away... I don't
>think this belongs in a separate commit.

That's a consequence of the compiler guarding the switches with all the
enums. The XML parser and QEMU command line formatter would ideally be
in separate commits, but due to the -Wswitch-enum option a complete
separation would fail.

Jano

>
>-- 
>Andrea Bolognani / Red Hat / Virtualization
>
>--
>libvir-list mailing list
>libvir-list at redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190212/1bc02bf2/attachment-0001.sig>