[libvirt] [PATCH v2 04/17] conf: Remove volOptions for VIR_STORAGE_POOL_ISCSI[_DIRECT]

John Ferlan jferlan at redhat.com
Tue Feb 12 15:28:03 UTC 2019


The iscsi and iscsi-direct pools are documented as not using
the volume type, so let's just remove it. Besides it would
have produced bad output since formatting uses the Disk types.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/conf/storage_conf.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 8cb0f75a91..e699057fbf 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -208,9 +208,6 @@ static virStoragePoolTypeInfo poolTypeInfo[] = {
                    VIR_STORAGE_POOL_SOURCE_DEVICE |
                    VIR_STORAGE_POOL_SOURCE_INITIATOR_IQN),
       },
-      .volOptions = {
-         .formatToString = virStoragePoolFormatDiskTypeToString,
-      }
     },
     {.poolType = VIR_STORAGE_POOL_ISCSI_DIRECT,
      .poolOptions = {
@@ -219,9 +216,6 @@ static virStoragePoolTypeInfo poolTypeInfo[] = {
                    VIR_STORAGE_POOL_SOURCE_NETWORK |
                    VIR_STORAGE_POOL_SOURCE_INITIATOR_IQN),
       },
-      .volOptions = {
-         .formatToString = virStoragePoolFormatDiskTypeToString,
-      }
     },
     {.poolType = VIR_STORAGE_POOL_SCSI,
      .poolOptions = {
-- 
2.20.1




More information about the libvir-list mailing list