[libvirt] [PATCH v3 11/17] qemu: Support memballoon model=virtio-{non-}transitional

Andrea Bolognani abologna at redhat.com
Tue Feb 12 16:08:51 UTC 2019


On Fri, 2019-02-08 at 17:12 -0500, Cole Robinson wrote:
[...]
> @@ -882,7 +882,10 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDefPtr dev,
>      case VIR_DOMAIN_DEVICE_MEMBALLOON:
>          switch ((virDomainMemballoonModel) dev->data.memballoon->model) {
>          case VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO:
> +        case VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO_NON_TRANSITIONAL:
>              return virtioFlags;
> +        case VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO_TRANSITIONAL:
> +            return pciFlags;

Same nit as in 8/17, please move the _TRANSITIONAL case first.

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list