[libvirt] [PATCH 2/5] qemuL: Drop "user-" prefix for guestfwd netdev

[Michal Privoznik]

On 2/12/19 11:08 PM, John Ferlan wrote:
> $SUBJ:
> 
> s/qemuL:/qemu:/
> 
> 
> On 2/11/19 10:40 AM, Michal Privoznik wrote:
>> Introduced by d86c876a66e3.
>>
>> There is no real need to have "user-" prefix for chardev.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>   src/qemu/qemu_command.c                                       | 2 +-
>>   tests/qemuxml2argvdata/channel-guestfwd.args                  | 2 +-
>>   .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args  | 4 ++--
>>   .../qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args | 4 ++--
>>   tests/qemuxml2argvdata/name-escape.args                       | 2 +-
>>   5 files changed, 7 insertions(+), 7 deletions(-)
>>
> 
> At least it wasn't "ua-" ;-)
> 
> Although I don't believe this patch is necessary. It's only made
> necessary because two patches from now qemuDomainDetachChrDevice wants
> to use tmpChr->info.alias instead of grabbing the alias that was used to
> generated the command line from qemuBuildChrDeviceStr out of the @devstr.
> 
> Let me hold off on an R-by for this until you give feedback on my patch4
> comments...

Given that guestfwd has a very limitted use case and that as you pointed 
out we switched it multiple times, there shouldn't be much problems with 
this. I rather be unable to detach guestfwd than come up with some 
complicated changes to our code just to allow it for domains started 
with older libvirt.

Michal