[libvirt] [PATCH 2/3] virjsontest: switch DO_TEST_PARSE_FILE to use output files

Andrea Bolognani abologna at redhat.com
Wed Feb 13 13:31:54 UTC 2019


On Tue, 2019-02-12 at 16:57 +0100, Ján Tomko wrote:
[...]
> +{"return":[{"filename":\
> +"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server",\
> +"label":"charmonitor"},{"filename":"pty:/dev/pts/158",\
> +"label":"charserial0"}],"id":"libvirt-3"}

Same questions as the previous patch when it comes to pretty
printing: it looks like...

[...]
> @@ -52,10 +55,8 @@ testJSONFromFile(const void *data)
>      if (!(actual = virJSONValueToString(injson, false)))
>          return -1;

... changing the second argument of virJSONValueToString() to true
is all that's needed to obtain much more legible output files. Any
reason why we shouldn't do that?

Everything else looks good.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list