[libvirt] [PATCH] qemu: Escape external snapshot names containing comma

[John Ferlan]

On 2/12/19 11:33 PM, Eric Blake wrote:
> The code for creating external snapshots for an offline domain
> called out to qemu-img without escaping commas in the manner
> that qemu-img expects. This also fixes a typo in the comment.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> 
> Noticed by code inspection; I did not try very hard to see how
> easy or hard it would be to convince libvirt to actually try
> and create an external snapshot to /path/file,with,comma to
> see how things break.
> 
>  src/qemu/qemu_driver.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 

Oh joy another place that uses qemu-img...

Looks like qemuDomainSnapshotForEachQcow2Raw uses virDomainDiskGetSource
or disk def->src->path as well for qemuimgarg[4].

Reviewed-by: John Ferlan <jferlan at redhat.com>

John