[libvirt] [jenkins-ci PATCH v3 05/10] lcitool: include root cause when reporting errors

Andrea Bolognani abologna at redhat.com
Thu Feb 14 10:12:48 UTC 2019


On Thu, 2019-02-14 at 09:59 +0000, Daniel P. Berrangé wrote:
> On Thu, Feb 14, 2019 at 10:46:21AM +0100, Andrea Bolognani wrote:
> > flake8 complains about this line being too long, so please rewrite
> > it as
> 
> What args (if any) are you giving to flake8 when you test this

No arguments, just straight up 'flake8 lcitool'.

> as if we
> want patches to pass flake8 tests we should add a makefile with a
> 'check' target.

It should probably be 'syntax-check' rather than 'check'.

> This would imply we should the make check in our CI
> system. Testing the test system is rather nicely recursive :-)

Yeah, that would be pretty neat :)

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list