[libvirt] [PATCH 7/7] conf: Rework virDomainDeviceDefPostParseCommon()

Andrea Bolognani abologna at redhat.com
Mon Feb 18 09:08:05 UTC 2019


On Mon, 2019-02-18 at 09:46 +0100, Bjoern Walk wrote:
> Andrea Bolognani <abologna at redhat.com> [2019-02-15, 12:55PM +0100]:
> > +    case VIR_DOMAIN_DEVICE_NONE:
> > +        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> > +                       _("unexpected VIR_DOMAIN_DEVICE_NONE"));
> 
> Can we find a better error message here?

Feel free to post a patch changing this (and the one in
qemuDomainDeviceDefPostParse() that I've copied it from :), but it's
one of those error messages that will only show up if we've made some
pretty serious mistake somewhere leading up to the function being
called, so I don't feel like it's particularly important for it to
be user friendly.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list