[libvirt] [PATCH v2 3/3] iohelper: Don't include newlines in error messages
John Ferlan
jferlan at redhat.com
Mon Feb 18 16:05:50 UTC 2019
On 2/13/19 7:04 AM, Andrea Bolognani wrote:
> The newline was pretty arbitrary, and we're better off
> without it.
>
> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
> src/util/iohelper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
I'm mostly ambivalent about this one; however, since
virGetLastErrorMessage could return a string without a "\n", then
perhaps it's best to keep the \n since it really doesn't hurt.
John
> diff --git a/src/util/iohelper.c b/src/util/iohelper.c
> index 1ff4a7b314..aed7ef3184 100644
> --- a/src/util/iohelper.c
> +++ b/src/util/iohelper.c
> @@ -236,7 +236,7 @@ main(int argc, char **argv)
> return 0;
>
> error:
> - fprintf(stderr, _("%s: failure with %s\n: %s"),
> + fprintf(stderr, _("%s: failure with %s: %s"),
> program_name, path, virGetLastErrorMessage());
> exit(EXIT_FAILURE);
> }
>
More information about the libvir-list
mailing list