[libvirt] [PATCH v2 6/6] block/dirty-bitmaps: move comment block

John Snow jsnow at redhat.com
Mon Feb 18 22:03:23 UTC 2019

On 2/18/19 12:39 PM, Vladimir Sementsov-Ogievskiy wrote:
> 14.02.2019 2:23, John Snow wrote:
>> Simply move the big status enum comment block to above the status
>> function, and document it as being deprecated. The whole confusing
>> block can get deleted in three releases time.
>> Signed-off-by: John Snow <jsnow at redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov at virtuozzo.com>
> But I think, it's OK to remove it now. It mostly unrelated to code now, so,
> is it needed? And it is unrelated to deprecation. As I understand, user-seen
> information is DirtyBitmapStatus declaration in qapi, and it is deprecated
> and to be removed in three releases.

I decided to keep it because I wanted to document the particulars of
what the fields meant internally before we finally remove it some future
release, in case we need to change this function around to maintain
backwards compatibility.

It'll get removed at that point in time.


More information about the libvir-list mailing list