[libvirt] [PATCHv2 0/2] network: add netmask to dhcp range of dnsmasq conf file for IPv4

[Laine Stump]

I sent V1 of this patch way back in October:

  https://www.redhat.com/archives/libvir-list/2018-October/msg00889.html

but then self-NACKed it because I had written the patch to add the
network prefix to dhcp-range, but IPv4 requires the netmask rather
than range. Unfortunately, when I modified the patch accordingly the
getnameinfo() function began failing, I couldn't immediately see why,
and I had to pack everything up and go to KVM Forum. After that, I
promptly forgot to look back at it.

Today I finally revisited the problem (after the person who originally
found it sent a reminder), and discovered the failure of getnameinfo()
was due to a bug in a function that I added to the virSocketAddr
library in 2010! 


Laine Stump (2):
  util: set missing data length in virSocketAddrPrefixToNetmask()
  network: add netmask to dhcp range of dnsmasq conf file for IPv4

 src/network/bridge_driver.c                   | 27 +++++++++++++++----
 src/util/virsocketaddr.c                      |  2 ++
 .../dhcp6-nat-network.conf                    |  2 +-
 .../networkxml2confdata/isolated-network.conf |  2 +-
 .../nat-network-dns-srv-record-minimal.conf   |  2 +-
 .../nat-network-dns-srv-record.conf           |  2 +-
 .../nat-network-dns-txt-record.conf           |  2 +-
 .../networkxml2confdata/nat-network-mtu.conf  |  2 +-
 .../nat-network-name-with-quotes.conf         |  2 +-
 tests/networkxml2confdata/nat-network.conf    |  2 +-
 .../networkxml2confdata/netboot-network.conf  |  2 +-
 .../netboot-proxy-network.conf                |  2 +-
 .../networkxml2confdata/ptr-domains-auto.conf |  2 +-
 13 files changed, 35 insertions(+), 16 deletions(-)

-- 
2.20.1